Features spec: update TM5 message action #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As agreed and implemented in ably/sdk-api-reference#44 (comment) , which was before I merged that repo into this, so the change is already made in api-docstrings.md but needs to be made in the features spec too This is technically a breaking change, but probably fine to just edit in-place (without changing the api version) since we don't yet have any public functionality that depends on the message action, and we're not planning on making serverside behaviour switch on api version, we're just going to make the change and have the chat sdk (which is what needs this) depend on new enough versions of released sdks
SimonWoolf
added a commit
to ably/ably-java
that referenced
this pull request
Jan 8, 2025
SimonWoolf
added a commit
to ably/ably-cocoa
that referenced
this pull request
Jan 8, 2025
This was referenced Jan 8, 2025
SimonWoolf
added a commit
to ably/ably-java
that referenced
this pull request
Jan 8, 2025
SimonWoolf
added a commit
to ably/ably-java
that referenced
this pull request
Jan 8, 2025
umair-ably
added a commit
to ably/ably-cocoa
that referenced
this pull request
Jan 9, 2025
SimonWoolf
added a commit
to ably/ably-cocoa
that referenced
this pull request
Jan 9, 2025
splindsay-92
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As agreed and implemented in
ably/sdk-api-reference#44 (comment) . Which was before I merged that repo into this, so this change is already made in api-docstrings.md, but needs to be made in the features spec too
This is technically a breaking change, but probably fine to just edit in-place (without changing the api version) since we don't yet have any public functionality that depends on the message action, and we're not planning on making serverside behaviour switch on api version, we're just going to make the change and have the chat sdk (which is what needs this) depend on new enough versions of released sdks